Skip to content

Enable scripts in in-app message iframe for Safari compatibility#574

Closed
franco-zalamena-iterable wants to merge 1 commit intoIterable:mainfrom
franco-zalamena-iterable:fix/490-safari-inapp-scripts
Closed

Enable scripts in in-app message iframe for Safari compatibility#574
franco-zalamena-iterable wants to merge 1 commit intoIterable:mainfrom
franco-zalamena-iterable:fix/490-safari-inapp-scripts

Conversation

@franco-zalamena-iterable
Copy link
Copy Markdown

@franco-zalamena-iterable franco-zalamena-iterable commented Apr 7, 2026

Summary

  • Add allow-scripts to iframe sandbox attribute for in-app messages
  • Remove Safari-specific restrictions that block click tracking

Test plan

  • Test in-app message click tracking in Safari
  • Test in-app message click tracking in Chrome
  • Verify custom actions (action://...) work in Safari

🤖 Generated with Claude Code

Add allow-scripts to the iframe sandbox attribute so that click event
handlers work inside the iframe on all browsers, including Safari.
Remove Safari-specific workarounds that were needed because scripts
were blocked, allowing Safari to use the same click-tracking code path
as other browsers. Fixes Iterable#490.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.89%. Comparing base (190a168) to head (952ecd2).

Files with missing lines Patch % Lines
src/inapp/inapp.ts 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
+ Coverage   74.45%   74.89%   +0.44%     
==========================================
  Files          57       57              
  Lines        2736     2709      -27     
  Branches      798      786      -12     
==========================================
- Hits         2037     2029       -8     
+ Misses        698      679      -19     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@franco-zalamena-iterable franco-zalamena-iterable deleted the fix/490-safari-inapp-scripts branch April 8, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants