Feedback for a great module.

[JustCarmen]

I just tried your new module and this looks very promissing! This will save a lot of time and effort! Thank you for that.

A few issues:

• The CustomModuleManager itself keeps saying there is a new version available while the latest version is already installed. This is because the version number is not updated in the beta1 test version.
• When opening the update page it would be nice to see which module is about to install and from which version to which version. You can see this info in the url, but not on the page itself.
• It would be nice if this module would show up in the 'Other' section of the Control Panel. This will reduce the number of clicks to open the module.
• Many modules have the text [English:] in front of the module title ánd description. I think you mean that these modules are only available in English, which isn't quite true. At least not for my modules. All my modules are translatable and at least translated into Dutch. Besides, the indicator makes the list clumsy. Wouldn't it be better to use an icon as an indicator? And why twice. Once would be enough.
• All my modules use the prefix 'jc-' inside the module v4 folder. Some modules are listed with the correct folder name, others do not. For example, webtrees-simple-footer is called jc-simple-footer in the modules_v4 folder. Note that this name is different from the name used on Github. On Github I use webtrees in the title as a prefix to make the modules easier to find.
• Sorting the table by title doesn't work well.

These are just a few remarks. Keep up with the good work!

[Jefferson49]

Hi Carmen,

thank you very much for testing my new module. It helps me a lot if experience modules other have a close look at the behavior.

The CustomModuleManager itself keeps saying there is a new version available while the latest version is already installed. This is because the version number is not updated in the beta1 test version.

Yes, this is a defect in the current version. I will fix it in the next release.

[Jefferson49]

It would be nice if this module would show up in the 'Other' section of the Control Panel. This will reduce the number of clicks to open the module.

I am not sure how I can move it to the "Other" section. I checked in the webtrees code and found the following about how other modules are defined:

https://github.com/fisharebest/webtrees/blob/main/app/Services/ModuleService.php#L847
* Configuration settings are available through the various "module component" pages.
* For modules that do not provide a component, we need to list them separately.

In order to avoid the number of clicks, I have created a menu item in the list menu, which is only visible for admin. I hope this helps.

[Jefferson49]

Many modules have the text [English:] in front of the module title ánd description. I think you mean that these modules are only available in English, which isn't quite true.

Maybe, I need to explain how I manage to provide the module information. For all modules, which are not installed, I cannot retrieve the module data from the modules themselves. Therefore, I generated a list of module names, title, and descriptions of all supported modules and stored it in a JSON string:
https://github.com/Jefferson49/CustomModuleManager/blob/main/src/Configuration/DefaultTitlesAndDescriptions.php

I can generate this JSON string on one of my webtrees installations, where all supported modules are installed.

At the moment, I only created the JSON list based on the English titles and descriptions. A first try to extract all languages failed, since the JSON created errors. I might rework on this later.

As long as I only have the English titles and descriptions, I decided to add this "[English:]" prefix

[Jefferson49]

All my modules use the prefix 'jc-' inside the module v4 folder. Some modules are listed with the correct folder name, others do not.

I tried to find an approach how to handle this in an equal way for all modules. Unfortunatelly, I need to handle a lot of different apprioaches by the module authors.

My general approach is:

• If a module is newly installed, I take the "standard" folder of the module
• If a module is updated, I take the same folder, which already exists in /modules_v4/

The "standard" folder is defined in my configuration file:
https://github.com/Jefferson49/CustomModuleManager/blob/main/src/Configuration/ModuleUpdateServiceConfiguration.php#L55

If I understood you correctly, you want to change the following folder/module names:

• webtrees-simple-footer => jc-webtrees-simple-footer
• webtrees-simple-media-display => jc-webtrees-simple-media-display
• webtrees-simple-menu => jc-webtrees-simple-menu

Is this correct?

[Jefferson49]

Sorting the table by title doesn't work well

Yes, I agree. I need to check. Maybe the handling of the [English:] titles can be easily improved.

Unfortunatelly, I am a newbie to the table HTML in webtrees. For the beginning, I copied some existing table from webtrees and need to gain more knowledge about the details.

[Jefferson49]

When opening the update page it would be nice to see which module is about to install and from which version to which version. You can see this info in the url, but not on the page itself.

That's a good point. I will add this.

[JustCarmen]

In order to avoid the number of clicks, I have created a menu item in the list menu, which is only visible for admin. I hope this helps.

Yes, that would be great. But what about the mypage menu? That might even be a better location, but I'm not sure if that is possible.

[JustCarmen]

If I understood you correctly, you want to change the following folder/module names:

• webtrees-simple-footer => jc-webtrees-simple-footer
• webtrees-simple-media-display => jc-webtrees-simple-media-display
• webtrees-simple-menu => jc-webtrees-simple-menu

Is this correct?

Almost:

• webtrees-simple-footer => jc-simple-footer
• webtrees-simple-media-display => jc-simple-media-display
• webtrees-simple-menu => jc-simple-menu

[Jefferson49]

webtrees-simple-footer => jc-simple-footer
webtrees-simple-media-display => jc-simple-media-display
webtrees-simple-menu => jc-simple-menu

Thanks for the clarification, I changed it accordingly.

[Jefferson49]

But what about the mypage menu? That might even be a better location, but I'm not sure if that is possible.

I have already checked that while working on other modules. I think it is not possible without modification of the webtrees code.

[JustCarmen]

But what about the mypage menu? That might even be a better location, but I'm not sure if that is possible.

I have already checked that while working on other modules. I think it is not possible without modification of the webtrees code.

Too bad, but the list menu is a good alternative.

[Jefferson49]

Fixed with: 832f748, 9ae9248, 69737d1, 83b63f0,