Enabling/disabling modules does not work well

[JustCarmen]

When you untick a checkbox and click the Save button, you would expect only the module with the unchecked box to be disabled, but that is not the case. Clicking the Save button disables ALL custom modules. This includes the custom module manager itself.

[Jefferson49]

I am sorry to hear that this happened. I remember that I faced the issue once during development of the module.

I tried to reproduce with the current code in two of my installations. However, could not reproduce it.

Are there any special circumstances? Anything specific before deactivating one of the modules?

[bschwede]

I can confirm this issue by @JustCarmen.
In my case I filtered and ticked just one module checkbox - 31 custom modules were disabled on saving.

[JustCarmen]

It happens to me even without filtering or sorting. Yesterday on my live site and today I reproduced the issue on my local test site.

[Jefferson49]

After a lot of testing, I finally found the root cause. The issue occurs, if only a part of the modules is selected/shown. For example, if the (default) setting "Display 10" is chosen. If "Display all" is chosen, everything works fine.

Therefore, I will take out all selections and filters for the table. I will now copy the table view and layout from the webtrees module list. The code to activate/deactivate modules, was already a 1:1 copy of this webtrees page anyway.

[Jefferson49]

Just recently, I published a bugfix release v2.0.1, which fixes the issue.