Skip to content

Don't expose schema for unexported fields #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smithamax merged 2 commits into from
Dec 2, 2025
Merged

Don't expose schema for unexported fields #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba967d1
Skip unexported fields in schema
smithamax Dec 2, 2025
12d728a
Add test
smithamax Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lokerpc/schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ func TypeSchema(t reflect.Type, tdefs map[reflect.Type]*NamedSchema) *jtd.Schema

for i := 0; i < t.NumField(); i++ {
f := t.Field(i)

if !f.IsExported() {
continue
}

name, omit := parseTag(f.Tag.Get("json"))
if name == "" {
name = f.Name
Expand Down
3 changes: 2 additions & 1 deletion lokerpc/schema_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ func (textMarshaler) MarshalText() ([]byte, error) {

func TestTypeSchema(t *testing.T) {
type NamedStruct struct {
Foo string `json:"foo"`
Foo string `json:"foo"`
nope string
}

// Name to conflict with flag.Flag
Expand Down