Skip to content

Include time package in codegen#18

Closed
THEjacob1000 wants to merge 1 commit intomasterfrom
feature/go-time-package
Closed

Include time package in codegen#18
THEjacob1000 wants to merge 1 commit intomasterfrom
feature/go-time-package

Conversation

@THEjacob1000
Copy link
Copy Markdown
Contributor

Internal change only

This update makes it so that it'll actually include the time package import when generating the go code

Submitter Checklist

Check only those that apply to this change.

  • Self-reviewed code, removed extraneous comments, debug logging, checked code style
  • No change to users after merge (off-by-default configuration, feature flag, alt URL, etc.) and can be disabled if issues arise (if this is not the case we may need stakeholder signoff)
  • Changes are documented (README, wiki, etc)
  • Automated tests added or existing tests cover the new functionality or changes
  • Manually tested changes
  • Metrics added to track the usage/performance
  • I am confident I can revert this change
  • Database migrations are reversible without data loss (if applicable)
  • Performance impact is acceptable (if applicable)
  • Any new dependencies are justified or have been approved (if applicable)
  • This is NOT a high risk change (if it is, please follow the high-risk change process)

Testing Evidence

What evidence supports that you have tested this change?

  • Test cases cover the new functionality or changes
  • Screenshots or logs of the changes (if applicable)
  • Performance benchmarks (if applicable)
  • Storybook cases (if applicable)

Reviewer Checklist

Note: if this PR affects authentication or payments please seek a secondary tester.

  • I am ok with code style and functionality
  • I have personally tested the feature
  • My review was not rushed due to time constraints

@THEjacob1000 THEjacob1000 self-assigned this Mar 13, 2026
@THEjacob1000 THEjacob1000 requested a review from smithamax March 13, 2026 03:36
@smithamax smithamax mentioned this pull request Mar 13, 2026
@smithamax
Copy link
Copy Markdown
Member

Walking the tree a second time kind of sucks, put up #19 as a better approach

@smithamax smithamax closed this Mar 13, 2026
@THEjacob1000 THEjacob1000 deleted the feature/go-time-package branch March 30, 2026 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants