Closed
Conversation
denwilliams
reviewed
Oct 15, 2024
Contributor
denwilliams
left a comment
denwilliams
left a comment
There was a problem hiding this comment.
Need to add instructions to readme for createConnection and also looks like you added close, so guessing that now needs to be called?
Member
Author
|
Pushed what I had on my computer, but not sure if this whole thing is a good approach, closing for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We could make this compatible with the old version, but thinking we make it a major version bump to make sure projects can't update without supporting reconnect