Handle channel close and consumer cancel cases#8
Merged
Conversation
Previously if the channel was canceled or the queue consumer was canceled we just hung not doing anything Now we exit the handleQueue, letting the caller re-run handleQueue if needed
J-tt
approved these changes
Apr 17, 2025
Contributor
J-tt
left a comment
J-tt
left a comment
There was a problem hiding this comment.
Implementation looks good, just had some questions around the sample code for using the library, but happy to touch on that in a follow up
| const doneP = (async () => { | ||
| // We loop here in case the rabbit channel closes and we need to restart | ||
| // the queue handler. | ||
| while (!aborter.signal.aborted) { |
Contributor
There was a problem hiding this comment.
Do we want to include a sleep interval or a retry limit in the sample code here?
Member
Author
There was a problem hiding this comment.
I think it's fine without
| // In this example we update a cache with the latest value from the queue. | ||
| // If we loose our our connection to the queue, we need to clear the cache | ||
| // and start again. | ||
| while (!aborter.signal.aborted) { |
Contributor
There was a problem hiding this comment.
Similar question around retry limits / sleeps in the loop as the other comment
Co-authored-by: Jett Jackson <jett.jackson@loke.com.au>
J-tt
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if the channel was canceled or the queue consumer was canceled we just hung not doing anything
Now we exit the handleQueue, letting the caller re-run handleQueue if needed