Skip to content

Update Version of AMQPlib#9

Merged
THEjacob1000 merged 1 commit intomasterfrom
feature/remove-possibility-of-broken-types-update
Aug 7, 2025
Merged

Update Version of AMQPlib#9
THEjacob1000 merged 1 commit intomasterfrom
feature/remove-possibility-of-broken-types-update

Conversation

@THEjacob1000
Copy link
Copy Markdown
Contributor

@THEjacob1000 THEjacob1000 commented Aug 6, 2025

Internal change only

Summary

After manually attempting to integrate this library into a new system (loke-manager), it was found that a patch version of @types/amqplib would break a lot of the types used throughout the package. The problematic version was v0.10.7, so this update removes the ^ from the version (preventing accidental version bumps if a future PR adjusts functionality) and updates to v0.10.6 which was found to be the latest version able to be used without breaking the types.

TLDR: updated dep version to remove "loose" versioning that would break types

Submitter Checklist

Check only those that apply to this change.

  • Self-reviewed code, removed extraneous comments, debug logging, checked code style
  • No change to users after merge (off-by-default configuration, feature flag, alt URL, etc.) and can be disabled if issues arise (if this is not the case we may need stakeholder signoff)
  • Changes are documented (README, wiki, etc)
  • Automated tests added
  • Manually tested changes
  • Metrics added to track the usage/performance
  • I am confident I can revert this change
  • Database migrations are reversible without data loss (if applicable)
  • Performance impact is acceptable (if applicable)
  • Any new dependencies are justified or have been approved (if applicable)
  • This is NOT a high risk change (if it is, please follow the high-risk change process)

Testing Evidence

What evidence supports that you have tested this change?

  • Test cases cover the new functionality or changes
  • Screenshots or logs of the changes (if applicable)
  • Performance benchmarks (if applicable)
  • Storybook cases (if applicable)

Reviewer Checklist

Note: if this PR affects authentication or payments please seek a secondary tester.

  • I am ok with code style and functionality
  • I have personally tested the feature
  • My review was not rushed due to time constraints

@THEjacob1000 THEjacob1000 self-assigned this Aug 6, 2025
@THEjacob1000 THEjacob1000 requested review from a team and peter-newman-loke and removed request for a team August 6, 2025 00:59
@peter-newman-loke
Copy link
Copy Markdown

Before I approve this, I'd like to see what the type changes are that this is working around

Copy link
Copy Markdown

@peter-newman-loke peter-newman-loke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting this as a workaround, seeing if the type issues can be fixed can be deferred until we need up update amqplib

@THEjacob1000 THEjacob1000 merged commit a4ca661 into master Aug 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants