Merged
Conversation
|
Before I approve this, I'd like to see what the type changes are that this is working around |
peter-newman-loke
approved these changes
Aug 7, 2025
peter-newman-loke
left a comment
There was a problem hiding this comment.
Accepting this as a workaround, seeing if the type issues can be fixed can be deferred until we need up update amqplib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal change only
Summary
After manually attempting to integrate this library into a new system (
loke-manager), it was found that a patch version of@types/amqplibwould break a lot of the types used throughout the package. The problematic version wasv0.10.7, so this update removes the^from the version (preventing accidental version bumps if a future PR adjusts functionality) and updates tov0.10.6which was found to be the latest version able to be used without breaking the types.TLDR: updated dep version to remove "loose" versioning that would break types
Submitter Checklist
Check only those that apply to this change.
Testing Evidence
What evidence supports that you have tested this change?
Reviewer Checklist
Note: if this PR affects authentication or payments please seek a secondary tester.