Conversation
…alidation for study dataset domain kinds only
…Validation = FALSE for DataClass domain kind
…f rows - add new labkey.query.import command to import via file upload - add docs for labkey.query.import - use labkey.query.import for labkey.domain.createAndLoad
@labkey-adam Thanks for the reminder. I have it on my list. I was planning to get these changes in with this PR and then do a follow-on mini-PR which actually did the version bump and release notes. I had planned to include that docs update in that PR but can just as easily add it here. |
| domainDesign = design, options = options) | ||
|
|
||
| labkey.insertRows(baseUrl = baseUrl, folderPath = folderPath, schemaName = schemaName, queryName= name, df) | ||
| labkey.query.import(baseUrl, folderPath, schemaName, queryName= name, toImport = df) |
There was a problem hiding this comment.
@labkey-klum What do you think of this change? The new labkey.query.import call is much faster then the labkey.insertRows or labkey.importRows calls. Do you recall any specific reason why the labkey.domain.createAndLoad would need to use the insertRows or do you think it is fine to change it to labkey.query.import?
There was a problem hiding this comment.
yes, agreed that changing this to use the new query.import function will improve the perf on this function.
|
Test plan for changes in this PR (note that the fix for Issue 43107 includes a small server side change against 21.3): Issue 43107: createAndLoad for Lists or Datasets using R returns an error
Issue 42950: Inserting file description using R API
Issue 42546: Improve performance of Rlabkey import for large number of rows
|
|
And here is a copy of the Rlabkey package built by TeamCity that can be installed locally for testing. |
Can you please also attach the doc pdf for testing? |


Rationale
Issue 43107: createAndLoad for Lists or Datasets using R returns an error
Issue 42950: Inserting file description using R API
Issue 42546: Improve performance of Rlabkey import for large number of rows
Related Pull Requests
Changes