Skip to content

Fix PI-purchased NHP flag date check#1684

Open
brentlogan wants to merge 2 commits intorelease25.11-SNAPSHOTfrom
25.11_fb_fixLeaseFeesForPIOwnedNHPs
Open

Fix PI-purchased NHP flag date check#1684
brentlogan wants to merge 2 commits intorelease25.11-SNAPSHOTfrom
25.11_fb_fixLeaseFeesForPIOwnedNHPs

Conversation

@brentlogan
Copy link
Copy Markdown
Collaborator

@brentlogan brentlogan commented Apr 6, 2026

Rationale

The date comparison between the assignment start date and the NHP-purchased flag included time, leading to unexpected failures.

Related Pull Requests

Changes

  • Simplify the assignment/PI-purchased flag date comparison code for lease fees and lease fee adjustments
  • Exempt PI-purchased NHPs from lease setup fees
  • Delete cut-and-paste error/duplicate code
  • Update comments
  • Minor formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant