Skip to content

7066: Dataset Designer Server Side API updates#1069

Merged
RosalineP merged 95 commits intodevelopfrom
fb_datasetDesignerStory3_7066
Apr 30, 2020
Merged

7066: Dataset Designer Server Side API updates#1069
RosalineP merged 95 commits intodevelopfrom
fb_datasetDesignerStory3_7066

Conversation

@RosalineP
Copy link
Copy Markdown
Contributor

@RosalineP RosalineP commented Apr 15, 2020 •
edited
Loading

Some notes:

  • We don't currently check to make sure that the dataset name is under a maximum amount of characters—do we want to add that?
  • Current code allows for a keyPropertyName that is the name of a column that is not numeric or string in type. Should this be changed? (Edit: This constraint to the type of the third key column only applies if the third key column is managed.)
  • If you change the name of a dataset in the options but not the domainDesign, it saves and changes the dataset name. Is this expected? The save does not go through if you change the domainDesign name but not the options name.
  • Category issue I noted

labkey-ankurj and others added 29 commits March 18, 2020 18:27
@labkey-ankurj
Item 6642: Starter files DatasetDesigner react app
0d643f8
@labkey-ankurj
Merge branch 'develop' into fb_datasetDesigner
12ae43b
@RosalineP
Merge remote-tracking branch 'remotes/origin/fb_datasetDesigner' into…
dcd2208 
… fb_datasetDesignerStory3_7066
@RosalineP
Merge branch 'develop' into fb_datasetDesignerStory3_7066
83b8ec1
@RosalineP
Work on moving functionality to DatasetDomainKind
bb91bd0
@RosalineP
Merge branch 'develop' into fb_datasetDesignerStory3_7066
7b6a4cc
@RosalineP
Merge branch 'develop' into fb_datasetDesignerStory3_7066
7a17b9c
@RosalineP
Merge branch 'develop' into fb_datasetDesignerStory3_7066
f5cad61
@RosalineP
Progress on managers, DDK, and DDKP
d27f87c
@RosalineP
Fix typo
6a98ff2
@RosalineP
Merge branch 'develop' into fb_datasetDesignerStory3_7066
48075d7
@RosalineP
Gets callable; update written and to be tested
b58997f
@RosalineP
Merge branch 'develop' into fb_datasetDesignerStory3_7066
1a471af
@RosalineP
Fix bugs in create and get
0028ac3
@RosalineP
Debugging update
b84c4f3
@labkey-ankurj
Merge branch 'develop' into fb_datasetDesignerStory3_7066
aa196e5
@RosalineP
Merge branch 'develop' into fb_datasetDesignerStory3_7066
df4240e
@RosalineP
Save, create, and get actions working. Continues work on validation
4230d7e
@labkey-ankurj
Item 7066: partial wrapper around DatasetDesigner
0d624ac
@labkey-ankurj
Merge remote-tracking branch 'origin/fb_datasetDesignerStory3_7066' i…
ffae505 
…nto fb_datasetDesignerStory3_7066
@RosalineP
Adds read-only properties to getDomainKindProperties. Addresses areas…
09fbf8b 
… flagged by me
@RosalineP
Merge remote-tracking branch 'origin/fb_datasetDesignerStory3_7066' i…
dcb11e2 
…nto fb_datasetDesignerStory3_7066
@cnathe
Study module package.json updates to match version and other minor up…
76fae0f 
…dates made to related platform modules
@RosalineP
Applies feedback from question-review round
3fa967f
@RosalineP
Merge remote-tracking branch 'origin/fb_datasetDesignerStory3_7066' i…
621a316 
…nto fb_datasetDesignerStory3_7066
@labkey-ankurj
Item 7066: partially working dataset designer wrapper to view existin…
ad4c6a1 
…g properties of dataset
@labkey-ankurj
Item 7066: partially working save dataset designer
d0dae01
@RosalineP
Handles more edge cases for create and update
80233a9
@RosalineP
Removes temp notes to myself
9367e8b
@RosalineP RosalineP requested a review from cnathe April 15, 2020 20:23
RosalineP and others added 18 commits April 27, 2020 12:41
@RosalineP
For create case, allows empty label in API call--populates label with…
55fd1c6 
… name given
@cnathe
Update to the latest @labkey/components alpha package version
bc8ae81
@cnathe
Add dataset designer message and link about datasets created from ass…
6b776db 
…ay copy-to-study
@cnathe
Add entityId to the DatasetDomainKindProperties so it can be used to …
e86dcda 
…determine if a dataset is new or existing
@cnathe
Fix for dataset validation check on managed field setting for additio…
f38464e 
…nal key
@labkey-ankurj
pulling in latest alpha version
3dadd00
@labkey-ankurj
pulling in latest alpha version
02b8e46
@labkey-ankurj
pulling in latest alpha version
b4494d4
@cnathe
Support for dataSharing prop in createAssayDataset via DatasetDomainK…
fbbf6b4 
…ind.createDomain() call
@cnathe
Update to the latest @labkey/components alpha package version
02fa766
@labkey-ankurj
Merge branch 'develop' into fb_datasetDesignerStory3_7066
ff20f4b
@labkey-ankurj
pulling in latest alpha version
c0fee0d
@cnathe
Automated test fix to account for dataset domain update without prope…
3bdfa84 
…rties / options
@RosalineP
Updates member variables to be private, and provides backwards compat…
c142df3 
…ibility for 'demographics' option
@RosalineP
Adds comment about backwards compatibility and removes related setter
81d79c8
@labkey-ankurj
merge develop into branch 'fb_datasetDesignerStory3_7066'
a67f022
@labkey-ankurj
pull beta version
3b2958a
@cnathe
Add in a few missing validation checks for DatasetDomainKind handling…
9e6e3f1 
… of useTimeKeyField
@RosalineP RosalineP merged commit 9e2e57d into develop Apr 30, 2020
@RosalineP RosalineP deleted the fb_datasetDesignerStory3_7066 branch April 30, 2020 16:04
cnathe added a commit that referenced this pull request May 17, 2021
@cnathe
Issue 43107: createAndLoad for Lists or Datasets using R returns an e…
b5071c9 
…rror

- add back in support for DatasetDomainKind strictFieldValidation
- inadvertently removed as part of #1069
@cnathe cnathe mentioned this pull request May 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cnathe cnathe cnathe approved these changes

+1 more reviewer

@labkey-ankurj labkey-ankurj labkey-ankurj left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

issue verification complete TeamCity test review complete

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RosalineP @labkey-jeckels @cnathe @labkey-ankurj @labkey-chrisj