Roundtrip wiki aliases through export/import and copy wiki#3235
Merged
labkey-adam merged 5 commits intodevelopfrom Apr 10, 2022
Merged
Roundtrip wiki aliases through export/import and copy wiki#3235labkey-adam merged 5 commits intodevelopfrom
labkey-adam merged 5 commits intodevelopfrom
Conversation
labkey-jeckels
approved these changes
Apr 10, 2022
|
|
||
| if (null != aliases) | ||
| { | ||
| WikiManager.get().addAliases(wikiInsert, aliases, null); |
Contributor
There was a problem hiding this comment.
Should we delete existing aliases if there aren't any being passed in?
Contributor
Author
There was a problem hiding this comment.
No need... this is insertWiki(), so there are no aliases associated with the brand new wiki.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Wiki aliases should be copied during folder export/import and copy wiki operations. https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=45207
Related Pull Requests