Item 5185: Zip Files for mass spec data#4
Conversation
cnathe
left a comment
cnathe
left a comment
There was a problem hiding this comment.
Comments/questions send via patch file in email.
| return; | ||
| } | ||
| //use colon(:) as file separator in case of firefox | ||
| if(window.navigator.userAgent.toLowerCase().indexOf("firefox") > -1) { |
There was a problem hiding this comment.
@labkey-ankurj
The comment above this if statement doesn't match.
Also, couldn't you just set the isFirefox variable directly?
var isFirefox = window.navigator.userAgent.toLowerCase().indexOf("firefox") > -1;
There was a problem hiding this comment.
oops, missed that comment. changed locally
| var dirPatterns; | ||
| var dropZone; | ||
| var filePattern =new RegExp(".*\\.zipme$"); | ||
| var firefox; |
There was a problem hiding this comment.
@labkey-ankurj
Inside of this ZipLoad.js, this variable is more about whether we expect all files to be read at once or if we need to batch them. So can we rename this variable accordingly (maybe something like: checkReadEntriesByBatch)?
There was a problem hiding this comment.
changed locally
3 participants
No description provided.