LIMS: Charting Story #3 - audit logs, cross folder & rendering improvements#5897
LIMS: Charting Story #3 - audit logs, cross folder & rendering improvements#5897
Conversation
… long/overlapping tick labels
# Conflicts: # assay/package-lock.json # assay/package.json # core/package-lock.json # core/package.json # experiment/package-lock.json # experiment/package.json # pipeline/package-lock.json # pipeline/package.json
# Conflicts: # assay/package-lock.json # assay/package.json # core/package-lock.json # core/package.json # experiment/package-lock.json # experiment/package.json # pipeline/package-lock.json # pipeline/package.json
… match R Report inherit checkbox perm check)
…reports and charts
|
|
||
| DatabaseReportCache.uncache(c); | ||
|
|
||
| ReportAuditProvider.ReportAuditEvent event = new ReportAuditProvider.ReportAuditEvent(reportDB, descriptor, c, reportExists ? "Report updated" : "Report created"); |
There was a problem hiding this comment.
Are we planning to audit for all report types, including, for example "SampleManager.SampleFinder" reports? (this comes free but just want to confirm)
There was a problem hiding this comment.
Also, what about hidden report, or user's private report?
There was a problem hiding this comment.
Re: SampleFinder saved searches/reports - I guess I wasn't intending on auditing those saves but it seems like a fine side effect. I think auditing them might be nice unless you see a reason we shouldn't?
Re: hidden and private reports - yes, this will audit those as well. Since we are just tracking the report id, name, reportKey, and type this seems fine to me. Can you think of a reason we shouldn't audit these?
| super(EVENT_NAME); | ||
|
|
||
| fields = new LinkedHashSet<>(); | ||
| fields.add(createPropertyDescriptor(COLUMN_NAME_REPORT_ID, PropertyType.STRING, "Report Id", null, true)); |
There was a problem hiding this comment.
Yes, good catch. I've changed it.
@XingY did you pull down this branch and start your server locally? If so, you'll have to do some manual database deletions to remove the domain so that it can change the reportId prop type. Let me know and I can give you my SQL script I used for the deletes locally.
# Conflicts: # core/package-lock.json # core/package.json # experiment/package-lock.json # experiment/package.json
# Conflicts: # core/package-lock.json # core/package.json
cnathe
added
issue verification complete
and removed
needs issue verification
needs TeamCity test review
labels
2 participants
Rationale
This PR adds audit events for insert/update/create of charts/reports, allows for Generic Chart reports to be inherited to child folders, and improves some rendering issues.
Related Pull Requests
Changes