Open
Conversation
XingY
changed the title
cnathe
approved these changes
Apr 2, 2026
| }, | ||
| "dependencies": { | ||
| "@labkey/components": "7.26.4" | ||
| "@labkey/components": "7.26.5-fb-mvtcBatch3.1" |
Contributor
There was a problem hiding this comment.
any reason not to also bump the @labkey/components version for the other package.json cases in platform? I think it is nice to keep all 4 of them in sync.
| var dialect = domainTable.getSchema().getSqlDialect(); | ||
| SQLFragment deletedArray = new SQLFragment("CAST(? AS TEXT[])").add(deletedValues.toArray(new String[0])); | ||
| SQLFragment columnFrag = new SQLFragment().appendIdentifier(column.getAlias()); | ||
| SQLFragment columnFrag = new SQLFragment().appendIdentifier(column.getName()); |
Contributor
There was a problem hiding this comment.
@XingY @labkey-matthewb I was hitting an exception when trying to update the list of values for a MVTC sample type field with a field named t$c. Please review, and decide if we need to add dedicated test coverage for this. Maybe it would be caught by fuzzing?
ERROR Table 2026-04-06T13:29:34,250 ttps-jsse-nio-443-exec-3 : SQL Exception with SQLState: 42703
org.postgresql.util.PSQLException: ERROR: column "t_c" does not exist
Hint: Perhaps you meant to reference the column "dollartesting.t$c".
Position: 923
at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2875)
org.springframework.jdbc.BadSqlGrammarException: ExecutingSelector; bad SQL grammar []
at org.springframework.jdbc.support.SQLStateSQLExceptionTranslator.doTranslate(SQLStateSQLExceptionTranslator.java:134)
at org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate(AbstractFallbackSQLExceptionTranslator.java:102)
at org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate(AbstractFallbackSQLExceptionTranslator.java:111)
at org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate(AbstractFallbackSQLExceptionTranslator.java:111)
at org.labkey.api.data.ExceptionFramework$1.translate(ExceptionFramework.java:43)
at org.labkey.api.data.SqlExecutingSelector$ExecutingResultSetFactory.handleSqlException(SqlExecutingSelector.java:570)
at org.labkey.api.data.SqlExecutingSelector$ExecutingResultSetFactory.handleResultSet(SqlExecutingSelector.java:469)
at org.labkey.api.data.SqlExecutingSelector.exists(SqlExecutingSelector.java:290)
at org.labkey.api.data.SqlExecutingSelector.exists(SqlExecutingSelector.java:283)
at org.labkey.api.exp.property.DomainUtil.updateDomainDescriptor(DomainUtil.java:994)
at org.labkey.experiment.api.SampleTypeServiceImpl.updateSampleType(SampleTypeServiceImpl.java:1192)
at org.labkey.api.exp.api.SampleTypeDomainKind.updateDomain(SampleTypeDomainKind.java:391)
at org.labkey.api.exp.api.SampleTypeDomainKind.updateDomain(SampleTypeDomainKind.java:83)
Contributor
Author
There was a problem hiding this comment.
@labkey-jeckels Good catch. I've pushed another change to use DatabaseIdentifier, will defer to @labkey-matthewb for future review. I've also modified AssayImportRunAction.ispec.ts to use fuzz field name, and the test already covers modifying option values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
GitHub Issue 951: Multi-line values converted to text choices lose multi-line editability
Related Pull Requests
Changes