move clientapi postToAction into dom/Utils.js#8
Closed
labkey-kevink wants to merge 1 commit intodevelopfrom
Closed
move clientapi postToAction into dom/Utils.js#8labkey-kevink wants to merge 1 commit intodevelopfrom
labkey-kevink wants to merge 1 commit intodevelopfrom
Conversation
Contributor
labkey-kevink
commented
Mar 26, 2019
labkey-kevink
commented
- consolidate three hidden form util methods into one
- move utility methods touching DOM into dom/Utils.js
- move utility methods touching DOM into dom/Utils.js
cnathe
approved these changes
Mar 27, 2019
Contributor
cnathe
left a comment
cnathe
left a comment
There was a problem hiding this comment.
See one comment related to the confirmAndPost impl.
| /** | ||
| * Documentation available in core/Util.js -- search for "@name confirmAndPost" | ||
| */ | ||
| impl.confirmAndPost = function (message, href) { |
Contributor
There was a problem hiding this comment.
Up in the documentation for this confirmAndPost in core/Utils.js, you had a third param for formData. Any reason that was left off here? I assume if it was added it would just be passed along to the formSubmit() call two lines down instead of the empty object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.