Add name keyword argument to loop.create_task()#334
Merged
fantix merged 1 commit intoMagicStack:masterfrom Apr 16, 2020
Merged
Conversation
Member
fantix
commented
Apr 11, 2020
fantix
commented
- Fixes BUG: uvloop.loop.create_task() is missing 'name' parameter #309.
- Refs bpo-34270.
* Fixes MagicStack#309. * Refs bpo-34270.
jlaine
reviewed
Apr 14, 2020
| # copied from asyncio.tasks._set_task_name (bpo-34270) | ||
| if name is not None: | ||
| try: | ||
| set_name = task.set_name |
Contributor
There was a problem hiding this comment.
Does this gain us something over the slightly more readable:
try:
task.set_name(name)
except AttributeError:
pass
Member
There was a problem hiding this comment.
It won't mask an AttributeError coming from the set_name implementation. Which is unlikely but can still happen especially with custom task factories.
Member
Author
There was a problem hiding this comment.
Thanks for the suggestion and comments!
I would write something like this:
if name is not None and hasattr(task, "set_name"):
task.set_name(name)But this is getting into details (try..except overhead? Two O(1) operations?) and stepping away from the copied code, so I think I'll merge as it is now.
1st1
approved these changes
Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.