Conversation
|
Thanks @rimjhimittal. Can you add the example to https://github.com/ModECI/MDF/blob/main/examples/MDF/README.mdwith a short description and saying it demonstrates the use of |
|
Hi @pgleeson , I have made the required changes, Please check. |
|
Thanks @rimjhimittal, looks good. Just for consistency though, could you move the notebook to the examples dir, and the png images to the images dir. See https://github.com/ModECI/MDF/blob/main/test_all.sh#L49. Also, for the final committed notebook, think about a reader who wants to see all the steps as clearly and quickly as possible. Most of the notebook is a printout of the output of the simulation at every timestep. Useful for debugging, but slightly inconvenient when you have to scroll through it all. Maybe put an optional |
|
Hi, Should i do something to hide this too? |
|
made the required changes |
|
Looks good, thanks @rimjhimittal |
This PR contains python file, notebook, plot, graph, json, yaml and changes in test file and Readme demonstrating Newton's Law of Cooling with MDF