fix(sandbox): redact sensitive structured log values#621
Closed
cluster2600 wants to merge 1 commit intoNVIDIA:mainfrom
Closed
fix(sandbox): redact sensitive structured log values#621cluster2600 wants to merge 1 commit intoNVIDIA:mainfrom
cluster2600 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
0051b28 to
f8d8087
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #595. Redact obvious secret-bearing structured log values in the sandbox log push path before they are sent to the gateway.
authorization,api_key,*_token,*_secret, and*_passwordBearer ...,sk-..., andopenshell:resolve:...l7_targetandtoken_countRationale
The current sandbox log push layer forwards structured tracing fields verbatim. That is usually fine for the existing events, but it means a future instrumentation change could accidentally forward credential material to the gateway. This change keeps the behaviour conservative and localised: only obvious secret-shaped structured fields are redacted, while the primary log message remains untouched.
flowchart LR A["Sandbox tracing event"] --> B{"Structured field?"} B -->|"no"| C["Keep message unchanged"] B -->|"yes"| D{"Sensitive name or value?"} D -->|"yes"| E["Replace with [REDACTED]"] D -->|"no"| F["Keep original value"] C --> G["PushSandboxLogs RPC"] E --> G F --> GChanges
crates/openshell-sandbox/src/log_push.rsrecord_strandrecord_debug; add 5 unit testsTest Plan
cargo test -p openshell-sandbox log_push::tests