Updated "generate_diagram.py" script

[apdavison]

based on changes by Julia Sprenger in #1026

[zm711]

Just one tiny thing to think about for the future. The color combinations aren't super friendly to people with color-blindness (green+red+blue-green-ish). Since the diagram is already a little tricky to wrap your head around we may want to watch out for this aqua vs red since they are currently conveying parts of the hierarchy.

[apdavison]

Thanks for the comment @zm711

I checked out the figure at https://www.color-blindness.com/coblis-color-blindness-simulator/ and I think that even for red-blindness the colours are distinct, but I'm happy to take suggestions for different colours.

[zm711]

As long as you check then it's probably good. I just like making sure that someone has checked. :)

[zm711]

I'm still figuring out where all the figures live in the repo, but this figure also is outdated no (since it has groups containing multiple segments?)

[apdavison]

this figure also is outdated no (since it has groups containing multiple segments?)

no. It is not a problem for a group to contain objects that belong to different segments, in fact that's one of the main use cases for Group.

(Groups can no longer contain entire Segment objects, but that is not shown in the figure)

[zm711]

Cool. So it would be incorrect if the the orange box was over one or both black boxes. I see. Thanks @apdavison !

[samuelgarcia]

Merci Andrew and Julia for this Heoric patch on this very old and dirty diagram generation code.