Eliminate CscRecordHeader#973
Merged
JuliaSprenger merged 2 commits intoNeuralEnsemble:masterfrom Jun 17, 2021
Merged
Conversation
|
Hello @PeterNSteinmetz! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-06-17 06:21:33 UTC |
Contributor
Author
|
Appears to be failing on NixIO. But let's hold off anyway until @JuliaSprenger has weighed in on the memmap performance issue. |
JuliaSprenger
force-pushed
the
speedHdrAccess
branch
from
6acae17 to
d24f525
Compare
Member
|
Hi Peter! Thanks for also looking into speed improvements! I rebased your branch onto master to have the latest version of the tests running. |
JuliaSprenger
approved these changes
Jun 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factored out the temporary variables of CscRecordHeader used in Ncs record scanning. Algorithm now reads directly from the memmap which is passed around. No allocation of an object within the loop. Hopefully this will eliminate the curious memory leak noted in issue #971.