Skip to content

CFE-4623: Fixed missing directory file separator suffix#263

Open
victormlg wants to merge 2 commits intoNorthernTechHQ:masterfrom
victormlg:append_file_sep
Open

CFE-4623: Fixed missing directory file separator suffix#263
victormlg wants to merge 2 commits intoNorthernTechHQ:masterfrom
victormlg:append_file_sep

Conversation

@victormlg
Copy link
Copy Markdown
Contributor

@victormlg victormlg commented Feb 16, 2026

No description provided.

@mender-test-bot
Copy link
Copy Markdown

mender-test-bot commented Feb 16, 2026

There was an error running your pipeline, see logs for details.

1 similar comment
@mender-test-bot
Copy link
Copy Markdown

mender-test-bot commented Feb 16, 2026

There was an error running your pipeline, see logs for details.

@mender-test-bot
Copy link
Copy Markdown

mender-test-bot commented Feb 16, 2026

There was an error running your pipeline, see logs for details.

@mender-test-bot
Copy link
Copy Markdown

mender-test-bot commented Feb 17, 2026

There was an error running your pipeline, see logs for details.

@mender-test-bot
Copy link
Copy Markdown

mender-test-bot commented Feb 17, 2026

There was an error running your pipeline, see logs for details.

larsewi
larsewi reviewed Feb 17, 2026
View reviewed changes
@mender-test-bot
Copy link
Copy Markdown

mender-test-bot commented Feb 17, 2026

There was an error running your pipeline, see logs for details.

@mender-test-bot
Copy link
Copy Markdown

mender-test-bot commented Feb 17, 2026

There was an error running your pipeline, see logs for details.

larsewi
larsewi reviewed Feb 17, 2026
View reviewed changes
@mender-test-bot
Copy link
Copy Markdown

mender-test-bot commented Feb 17, 2026

There was an error running your pipeline, see logs for details.

@victormlg victormlg requested a review from larsewi February 17, 2026 15:01
larsewi
larsewi requested changes Feb 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to use IsDir() which follows symbolic links

craigcomstock
craigcomstock previously approved these changes Feb 20, 2026
View reviewed changes
@mender-test-bot
Copy link
Copy Markdown

mender-test-bot commented Feb 24, 2026

There was an error running your pipeline, see logs for details.

@victormlg victormlg mentioned this pull request Feb 24, 2026
Closed
@mender-test-bot
Copy link
Copy Markdown

mender-test-bot commented Mar 16, 2026

There was an error running your pipeline, see logs for details.

@victormlg victormlg requested a review from larsewi March 16, 2026 10:25
larsewi
larsewi requested changes Mar 16, 2026
View reviewed changes
@mender-test-bot
Copy link
Copy Markdown

mender-test-bot commented Mar 16, 2026

There was an error running your pipeline, see logs for details.

larsewi
larsewi approved these changes Mar 16, 2026
View reviewed changes
@larsewi
Copy link
Copy Markdown
Contributor

larsewi commented Mar 16, 2026

@cf-bottom Jenkins please :)

@cf-bottom
Copy link
Copy Markdown

cf-bottom commented Mar 16, 2026

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/13448/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13448/

larsewi
larsewi requested changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests (3 failures / +3)
./01_vars/02_functions/findfiles.cf.findfiles.cf
./01_vars/02_functions/findfiles_up.cf.findfiles_up.cf
./04_examples/outputs/check_outputs.cf.check_outputs.cf

@mender-test-bot
Copy link
Copy Markdown

mender-test-bot commented Mar 25, 2026

There was an error running your pipeline, see logs for details.

@mender-test-bot
Copy link
Copy Markdown

mender-test-bot commented Mar 25, 2026

There was an error running your pipeline, see logs for details.

@victormlg victormlg mentioned this pull request Mar 25, 2026
Open
@victormlg
Fixed missing directory file separator suffix
588c1ff 
Ticket: CFE-4623
Signed-off-by: Victor Moene <victor.moene@northern.tech>
@victormlg
Fixed unit tests for directory separator suffix
2053487
@mender-test-bot
Copy link
Copy Markdown

mender-test-bot commented Mar 25, 2026

There was an error running your pipeline, see logs for details.

@victormlg
Copy link
Copy Markdown
Contributor Author

victormlg commented Mar 25, 2026 •
edited
Loading

Running with fixed tests:

Build Status

@victormlg
Copy link
Copy Markdown
Contributor Author

victormlg commented Mar 25, 2026

One more time:

Build Status

@victormlg victormlg mentioned this pull request Mar 26, 2026
Open
@victormlg
Copy link
Copy Markdown
Contributor Author

victormlg commented Mar 26, 2026

Fixed masterfiles:

Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsewi larsewi larsewi requested changes

@craigcomstock craigcomstock craigcomstock left review comments

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@victormlg @mender-test-bot @larsewi @cf-bottom @craigcomstock