fix: handle clipboard Error when image is in clipboard (#196)#283
Open
dowel015 wants to merge 1 commit intoOpenIntegrationEngine:mainfrom
Open
fix: handle clipboard Error when image is in clipboard (#196)#283dowel015 wants to merge 1 commit intoOpenIntegrationEngine:mainfrom
dowel015 wants to merge 1 commit intoOpenIntegrationEngine:mainfrom
Conversation
…onEngine#196) Catch Error (e.g. IllegalAccessError from JAI's PNMImageWriter) thrown during clipboard inspection in PasteAction.isEnabled(), log a warning, and return false instead of crashing the Admin UI on login. Signed-off-by: Joshua Dowell <joshua.dowell@centrallogic.com>
mgaffigan
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PasteAction.isEnabled()callsclipboard.getContents()to check for pasteable content, which triggers JAI'sPNMImageWriterinitialization on LinuxPNMImageWriterattempts to accesssun.security.action.GetPropertyAction, a sealed internal JDK class, throwingIllegalAccessErrorunder Java 17IllegalStateException, so theErrorpropagated up and crashed the Admin UI on logincatch (Error e)block that logs a warning and returnsfalse, keeping the paste action disabled without crashingFixes #196
Test plan