Skip to content

add blog post about typer#96

Merged
xmnlab merged 1 commit intoOpenScienceLabs:mainfrom
xmnlab:add-typer
Jan 12, 2024
Merged

add blog post about typer#96
xmnlab merged 1 commit intoOpenScienceLabs:mainfrom
xmnlab:add-typer

Conversation

@xmnlab
Copy link
Member

@xmnlab xmnlab commented Jan 11, 2024

No description provided.

@xmnlab xmnlab requested a review from EverVino January 11, 2024 22:45
@xmnlab
Copy link
Member Author

xmnlab commented Jan 11, 2024

@EverVino could you review this pr please? thanks!

Copy link
Contributor

@EverVino EverVino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @xmnlab thanks.
Just one question. The python files are there as examples and for future references. right?

@xmnlab
Copy link
Member Author

xmnlab commented Jan 12, 2024

@EverVino , yes .. that files are created automatically by the jupyter notebook (%%writefile) ... I don't think that it would be a problem to track on git ... but another option would be to add a .gitignore ... but thinking about a generic workflow for everyone, I think that it would be easy to track the files instead of adding a .gitignore ... or add a rule *.py for everything inside the blog page ..

I think we can discuss that for a follow up .. and maybe update the documentation to keep it clear about the correct workflow

@xmnlab
Copy link
Member Author

xmnlab commented Jan 12, 2024

thanks for the review!

@xmnlab xmnlab merged commit e3c004c into OpenScienceLabs:main Jan 12, 2024
@xmnlab xmnlab deleted the add-typer branch January 12, 2024 01:06
Satarupa22-SD pushed a commit to Satarupa22-SD/opensciencelabs.github.io that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants