Modernize README.md with detailed project info and styling#3
Modernize README.md with detailed project info and styling#3GhostTypes merged 2 commits intomainfrom
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
When index.html is not found during SPA fallback, the code now returns a
proper 500 server error with a clear message instead of a misleading 404.
This correctly indicates a build/deployment error rather than a user request
error.
Also fixes pre-existing ESLint configuration issues:
- Configured separate TypeScript project configs for backend and frontend
code to resolve parsing errors in src/webui/static files
- Added test files to tsconfig.json include array
- Replaced conditional require() with proper ES6 top-level import
for Windows readline handling
Changes:
- WebUIManager: Return AppError with ErrorCode.CONFIG_INVALID when
index.html is missing, including contextual debugging information
- WebUIManager: Added defensive documentation explaining why
path.extname() check is safe (app doesn't use client-side routing)
- eslint.config.mjs: Split configuration for backend (CommonJS) and
frontend (ES modules) with appropriate tsconfig references
- tsconfig.json: Added test files to include array
- index.ts: Replaced conditional require('readline') with top-level import
Fixes #10 comment #3 (Gemini Code Assist review)
1 participant
Replaced the existing README with a modern, centered layout using HTML formatting.
Added comprehensive sections for Overview, Core Features, Supported Printers, Installation, Configuration, and Development.
Documented key features like multi-printer support, camera streaming, and Spoolman integration based on codebase analysis.
Used tables for structured data presentation and badges for quick project stats.
PR created automatically by Jules for task 18220267775671167386 started by @GhostTypes