Add --scalar-columns parameter to NIfTI and MIF CLIs#34
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 61.19% 58.16% -3.04%
==========================================
Files 16 17 +1
Lines 951 1023 +72
Branches 137 161 +24
==========================================
+ Hits 582 595 +13
- Misses 332 386 +54
- Partials 37 42 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
I think the way to go here is to make multiple h5 files, since using that is supported in ModelArray now. This won't make a difference for tiledb, since the scalars all go into different files in its root directory anyways. Separate h5's let users mix and match when modeling and also the reshaping from long to wide during the ModelArray runs adds up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32. Closes #33.