Add features for conversion QC and scalar export to original formats#40
Open
mattcieslak wants to merge 1 commit intomainfrom
Open
Add features for conversion QC and scalar export to original formats#40mattcieslak wants to merge 1 commit intomainfrom
mattcieslak wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
- Coverage 61.19% 0.00% -61.20%
==========================================
Files 16 1 -15
Lines 951 18 -933
Branches 137 0 -137
==========================================
- Hits 582 0 -582
+ Misses 332 18 -314
+ Partials 37 0 -37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tsalo
reviewed
Mar 27, 2026
| *********** | ||
| nifti-to-h5 | ||
| ********** | ||
| ************ |
Member
There was a problem hiding this comment.
Suggested change
| ************ | |
| *********** |
tsalo
reviewed
Mar 27, 2026
Member
tsalo
left a comment
tsalo
left a comment
There was a problem hiding this comment.
One thought- it would be nice to cover the ValueErrors in the tests.
Member
There was a problem hiding this comment.
The about.py shouldn't be committed. It needs to be added to the gitignore.
|
|
||
|
|
||
| def add_diagnostics_args(parser): | ||
| parser.add_argument( |
Member
There was a problem hiding this comment.
I think it would be better to make this mutually exclusive with --diagnostics-maps and directly set diagnostic_maps to None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #37
closes #35