Pytype fix#2153

Merged

wyli merged 4 commits intoProject-MONAI:devfrom

rijobro:pytype_fix

May 6, 2021

Contributor

rijobro commented May 6, 2021

Fixes #2121 (comment).

Description

Avoid most recent pytype (2021.05.04) due to google/pytype#909.

Status

Ready

Types of changes

Non-breaking change (fix or new feature that would not break existing functionality).

rijobro added 2 commits

May 6, 2021 16:58


          skip most recent pytype

adc11df

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>


          avoid pytype 2021.05.04

8dbcc8d

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

rijobro requested a review from wyli

May 6, 2021 16:03

wyli approved these changes

View reviewed changes

Contributor

wyli left a comment

thanks this is nice

wyli enabled auto-merge (squash)

May 6, 2021 16:04


          pytype<2021

832831e

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

Contributor

wyli commented May 6, 2021

according to the pytype ticket, looks like it's actually the attrs issue... https://github.com/python-attrs/attrs/releases

wyli disabled auto-merge

May 6, 2021 16:17

Contributor Author

rijobro commented May 6, 2021

Ok. So we add in attrs<21.1.0 before pytype and then remove it once their issue is closed?


          old attrs

d298420

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

Contributor Author

rijobro commented May 6, 2021

Also looks like the attrs bug has already been fixed, so the problem will solve itself when they do their next release.

Contributor

wyli commented May 6, 2021

Also looks like the attrs bug has already been fixed, so the problem will solve itself when they do their next release.

shall we close this and wait?

Contributor Author

rijobro commented May 6, 2021

no, we have no idea when they'll release the next tag, I think we should merge and then revert when possible. Otherwise we can't merge any other PRs in the meantime.

wyli enabled auto-merge (squash)

May 6, 2021 16:34

Contributor

wyli commented May 6, 2021

sounds good

rijobro mentioned this pull request

remove attrs from pip requirements #2154

Closed

wyli merged commit 9c62769 into Project-MONAI:dev

wyli added a commit that referenced this pull request


          Revert "Pytype fix (#2153)"

526cab6

This reverts commit 9c62769.

wyli added a commit to wyli/MONAI that referenced this pull request


          Revert "Pytype fix (Project-MONAI#2153)"

15001a0

This reverts commit 9c62769.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

rijobro deleted the pytype_fix branch

May 7, 2021 08:24

wyli added a commit that referenced this pull request


          Revert "Pytype fix (#2153)" (#2157)

2a4c9e5

This reverts commit 9c62769.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

yanielc pushed a commit to yanielc/MONAI that referenced this pull request


          Pytype fix (Project-MONAI#2153)

e47c250

* skip most recent pytype

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* pytype<2021

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* old attrs

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

yanielc pushed a commit to yanielc/MONAI that referenced this pull request


          Revert "Pytype fix (Project-MONAI#2153)" (Project-MONAI#2157)

4b44c70

This reverts commit 9c62769.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

yanielc pushed a commit to yanielc/MONAI that referenced this pull request


          Pytype fix (Project-MONAI#2153)

2a3d749

* skip most recent pytype

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* pytype<2021

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* old attrs

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

yanielc pushed a commit to yanielc/MONAI that referenced this pull request


          Revert "Pytype fix (Project-MONAI#2153)" (Project-MONAI#2157)

7cf24d2

This reverts commit 9c62769.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

yanielc pushed a commit to yanielc/MONAI that referenced this pull request


          Pytype fix (Project-MONAI#2153)

d659f4a

* skip most recent pytype

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* pytype<2021

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* old attrs

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

yanielc pushed a commit to yanielc/MONAI that referenced this pull request


          Revert "Pytype fix (Project-MONAI#2153)" (Project-MONAI#2157)

7084d46

This reverts commit 9c62769.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

yanielc pushed a commit to yanielc/MONAI that referenced this pull request


          Pytype fix (Project-MONAI#2153)

32a8a6d

* skip most recent pytype

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* pytype<2021

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* old attrs

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

yanielc pushed a commit to yanielc/MONAI that referenced this pull request


          Revert "Pytype fix (Project-MONAI#2153)" (Project-MONAI#2157)

6e2aae7

This reverts commit 9c62769.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

yanielc pushed a commit to yanielc/MONAI that referenced this pull request


          Pytype fix (Project-MONAI#2153)

fac06a6

* skip most recent pytype

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* pytype<2021

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* old attrs

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

yanielc pushed a commit to yanielc/MONAI that referenced this pull request


          Revert "Pytype fix (Project-MONAI#2153)" (Project-MONAI#2157)

9e6e4cf

This reverts commit 9c62769.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

yanielc pushed a commit to yanielc/MONAI that referenced this pull request


          Pytype fix (Project-MONAI#2153)

8bb7438

* skip most recent pytype

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* pytype<2021

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* old attrs

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

yanielc pushed a commit to yanielc/MONAI that referenced this pull request


          Revert "Pytype fix (Project-MONAI#2153)" (Project-MONAI#2157)

79540bd

This reverts commit 9c62769.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>

wyli pushed a commit that referenced this pull request


          Pytype fix (#2153)

e71e7ea

* skip most recent pytype

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* pytype<2021

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* old attrs

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

wyli added a commit that referenced this pull request


          Revert "Pytype fix (#2153)" (#2157)

8276fd0

This reverts commit 9c62769.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

wyli pushed a commit that referenced this pull request


          Pytype fix (#2153)

8a61e2c

* skip most recent pytype

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* pytype<2021

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* old attrs

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

wyli added a commit that referenced this pull request


          Revert "Pytype fix (#2153)" (#2157)

bc2a10d

This reverts commit 9c62769.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

wyli pushed a commit that referenced this pull request


          Pytype fix (#2153)

ab872cd

* skip most recent pytype

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* pytype<2021

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* old attrs

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

wyli added a commit that referenced this pull request


          Revert "Pytype fix (#2153)" (#2157)

06b0732

This reverts commit 9c62769.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

wyli pushed a commit that referenced this pull request


          Pytype fix (#2153)

2b8957f

* skip most recent pytype

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* pytype<2021

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

* old attrs

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

wyli added a commit that referenced this pull request


          Revert "Pytype fix (#2153)" (#2157)

e0975f7

This reverts commit 9c62769.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet