Add `compile` support in `SupervisedTrainer` and `SupervisedEvaluator` by KumoLiu · Pull Request #7375 · Project-MONAI/MONAI

KumoLiu · 2024-01-08T15:35:56Z

Fixes # .

Description

Add compile support in SupervisedTrainer and SupervisedEvaluator.
Convert to torch.Tensor internally.

Types of changes

Non-breaking change (fix or new feature that would not break existing functionality).
Breaking change (fix or new feature that would cause existing functionality to change).
New tests added to cover the changes.
Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
In-line docstrings updated.
Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

monai/engines/evaluator.py

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

KumoLiu · 2024-01-16T09:53:05Z

From the suggestion here, I tried torch-nightly. I can run the pipeline without converting MetaTensor to tensor after updating traceable_tensor_subclasses.

But as mentioned here, this feature doesn't really work and will not preserve the meta information.
https://github.com/pytorch/pytorch/blob/13473df0d770e67f92cb4bb1b728f3746f160b7c/torch/_dynamo/config.py#L101-L112

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

ericspod · 2024-01-16T18:32:23Z

I'm not sure that the support in Pytorch will be stable soon to be compatible with MetaTensor. If we want to integrate this we'll have to put a warning into the docstring stating that MetaTensor will be cast away. We could consider casting back to MetaTensor after the forward pass and copying the metadata from the original but this is different behaviour again that may not make things better.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

for more information, see https://pre-commit.ci

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

KumoLiu · 2024-01-17T07:50:32Z

I'm not sure that the support in Pytorch will be stable soon to be compatible with MetaTensor. If we want to integrate this we'll have to put a warning into the docstring stating that MetaTensor will be cast away. We could consider casting back to MetaTensor after the forward pass and copying the metadata from the original but this is different behaviour again that may not make things better.

Thanks, Eric for your suggestions, I have added a warning and also mentioned it in the docstring, I cast back to the MetaTensor after the forward pass. Could you please help review it again? Then I will add some tests.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

monai/engines/evaluator.py

ericspod

Looks good to me now, I had just a minor suggestion for the comment that should be in the Evaluator and Trainer classes.

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

for more information, see https://pre-commit.ci

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

KumoLiu · 2024-01-18T15:05:15Z

/build

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

…h2-1

KumoLiu · 2024-01-19T02:32:12Z

/build

KumoLiu · 2024-01-19T03:48:27Z

Known issue list here as a reminder. pytorch/pytorch#117026

KumoLiu · 2024-01-19T07:12:27Z

/build

Project-MONAI#7375) Fixes # . ### Description Add `compile` support in `SupervisedTrainer` and `SupervisedEvaluator`. Convert to `torch.Tensor` internally. ### Types of changes  - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Mark Graham <markgraham539@gmail.com>

Project-MONAI#7375) Fixes # . ### Description Add `compile` support in `SupervisedTrainer` and `SupervisedEvaluator`. Convert to `torch.Tensor` internally. ### Types of changes  - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>

Project-MONAI#7375) Fixes # . ### Description Add `compile` support in `SupervisedTrainer` and `SupervisedEvaluator`. Convert to `torch.Tensor` internally. ### Types of changes  - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>

KumoLiu added 3 commits January 8, 2024 15:32

add compile arg

364eb99

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

Merge remote-tracking branch 'origin/dev' into torch2-1

371d888

fix flake8

ec2090d

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

ericspod reviewed Jan 9, 2024

View reviewed changes

monai/engines/evaluator.py Outdated Show resolved Hide resolved

ericspod reviewed Jan 9, 2024

View reviewed changes

monai/engines/evaluator.py Outdated Show resolved Hide resolved

KumoLiu and others added 6 commits January 9, 2024 17:22

Update monai/engines/evaluator.py

a57b188

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

Merge remote-tracking branch 'origin/dev' into torch2-1

516bf34

address comments

3f9dfb2

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

fix flake8

707259d

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

fix ci

1c5a1fd

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

minor fix

b65cbce

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

Nic-Ma mentioned this pull request Jan 15, 2024

torch._dynamo.exc.InternalTorchDynamoError: ListIteratorVariable() has no type pytorch/pytorch#117026

Closed

KumoLiu added 2 commits January 16, 2024 17:56

Merge branch 'dev' into torch2-1

6e2af5f

add fixme

c3b9b96

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

KumoLiu and others added 4 commits January 17, 2024 15:02

add meta back

c6fbe8c

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

631b24f

for more information, see https://pre-commit.ci

add meta back

aeb4be9

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

fix flake8

2ba99df

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

fix flake8

c9b8115

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

ericspod reviewed Jan 17, 2024

View reviewed changes

monai/engines/evaluator.py Outdated Show resolved Hide resolved

ericspod approved these changes Jan 17, 2024

View reviewed changes

KumoLiu and others added 5 commits January 18, 2024 12:48

Update monai/engines/evaluator.py

02e088b

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

Merge remote-tracking branch 'yliu/torch2-1' into torch2-1

f89b35c

[pre-commit.ci] auto fixes from pre-commit.com hooks

f3ae748

for more information, see https://pre-commit.ci

Merge remote-tracking branch 'yliu/torch2-1' into torch2-1

e82e8e8

address comments

7e21211

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

KumoLiu marked this pull request as ready for review January 18, 2024 04:51

Merge branch 'dev' into torch2-1

9b4aee0

KumoLiu added 3 commits January 19, 2024 10:28

fix mypy

10051df

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>

Merge remote-tracking branch 'origin/dev' into torch2-1

fcaa8cd

Merge branch 'torch2-1' of https://github.com/KumoLiu/MONAI into torc…

ba30578

…h2-1

KumoLiu enabled auto-merge (squash) January 19, 2024 02:41

KumoLiu requested a review from Nic-Ma January 19, 2024 02:41

KumoLiu merged commit facf176 into Project-MONAI:dev Jan 19, 2024

KumoLiu deleted the torch2-1 branch January 19, 2024 08:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `compile` support in `SupervisedTrainer` and `SupervisedEvaluator`#7375

Add `compile` support in `SupervisedTrainer` and `SupervisedEvaluator`#7375
KumoLiu merged 25 commits intoProject-MONAI:devfrom
KumoLiu:torch2-1

KumoLiu commented Jan 8, 2024

Uh oh!

Uh oh!

Uh oh!

KumoLiu commented Jan 16, 2024

Uh oh!

ericspod commented Jan 16, 2024

Uh oh!

KumoLiu commented Jan 17, 2024

Uh oh!

Uh oh!

ericspod left a comment

Uh oh!

KumoLiu commented Jan 18, 2024

Uh oh!

KumoLiu commented Jan 19, 2024

Uh oh!

KumoLiu commented Jan 19, 2024

Uh oh!

KumoLiu commented Jan 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

KumoLiu commented Jan 8, 2024

Description

Types of changes

Uh oh!

Uh oh!

Uh oh!

KumoLiu commented Jan 16, 2024

Uh oh!

ericspod commented Jan 16, 2024

Uh oh!

KumoLiu commented Jan 17, 2024

Uh oh!

Uh oh!

ericspod left a comment

Choose a reason for hiding this comment

Uh oh!

KumoLiu commented Jan 18, 2024

Uh oh!

KumoLiu commented Jan 19, 2024

Uh oh!

KumoLiu commented Jan 19, 2024

Uh oh!

KumoLiu commented Jan 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants