Skip to content

[UPDATE] Adding placeholder for google Analytics#67

Merged
AakashGfude merged 4 commits intomasterfrom
analytics-id
Oct 26, 2020
Merged

[UPDATE] Adding placeholder for google Analytics#67
AakashGfude merged 4 commits intomasterfrom
analytics-id

Conversation

@AakashGfude
Copy link
Member

@AakashGfude AakashGfude commented Oct 8, 2020

IMPORTANT : put the analytics id of lecture-python-programming here before merging the PR.

Just a placeholder for the correct location of google analytics id

@github-actions github-actions bot temporarily deployed to commit October 8, 2020 01:23 Inactive
@AakashGfude AakashGfude requested a review from mmcky October 8, 2020 01:24
@mmcky
Copy link
Contributor

mmcky commented Oct 8, 2020

ok great - so that config will just flow through to our html using quantecon_book_theme?

@AakashGfude
Copy link
Member Author

ok great - so that config will just flow through to our html using quantecon_book_theme?

That's right

DrDrij added a commit that referenced this pull request Oct 23, 2020
@github-actions github-actions bot temporarily deployed to commit October 23, 2020 03:09 Inactive
@github-actions github-actions bot temporarily deployed to commit October 25, 2020 03:28 Inactive
@mmcky
Copy link
Contributor

mmcky commented Oct 26, 2020

@AakashGfude and @DrDrij should this now be merged?

@AakashGfude
Copy link
Member Author

@mmcky should be ready to merge now.

@AakashGfude AakashGfude merged commit 38a2ebd into master Oct 26, 2020
AakashGfude added a commit that referenced this pull request Oct 26, 2020
* added plugins config

* renaming folder and path

* Added GA code for programming lectures #67

* Add new html metadata variables

Co-authored-by: DrDrij <dr.drij@gmail.com>
@github-actions github-actions bot temporarily deployed to commit October 26, 2020 04:16 Inactive
AakashGfude added a commit that referenced this pull request Oct 26, 2020
* added plugins config

* renaming folder and path

* Added GA code for programming lectures #67

* Add new html metadata variables

Co-authored-by: DrDrij <dr.drij@gmail.com>
AakashGfude added a commit that referenced this pull request Oct 26, 2020
* added url for repo

* added confid values

* adjusted some variables

* [UPDATE] Adding placeholder for google Analytics (#67)

* added plugins config

* renaming folder and path

* Added GA code for programming lectures #67

* Add new html metadata variables

Co-authored-by: DrDrij <dr.drij@gmail.com>

* minor edit

Co-authored-by: DrDrij <dr.drij@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants