feat: [OpenAPI] withDefaultHeader on Api classes#1130
Open
feat: [OpenAPI] withDefaultHeader on Api classes#1130
withDefaultHeader on Api classes#1130Conversation
newtork
reviewed
Mar 31, 2026
| final TypeReference<OpenApiResponse> localVarReturnType = new TypeReference<OpenApiResponse>() {}; | ||
| {{/returnType}} | ||
|
|
||
| return apiClient.invokeAPI( |
Contributor
There was a problem hiding this comment.
(Major)
This looks unexpected.
Member
Author
There was a problem hiding this comment.
Otherwise, we would be making an actual ApiClient#invokeAPI call instead of delegating to BaseApi. Did I miss something?
Contributor
There was a problem hiding this comment.
You could put the relevant code here. just above (original) apiClient.invokeAPI(
final var mergedHeaderParams = new HashMap<>(defaultHeaders);
mergedHeaderParams.putAll(headerParams);`
Contributor
CharlesDuboisSAP
left a comment
CharlesDuboisSAP
left a comment
There was a problem hiding this comment.
I would prefer this to #1129
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
SAP/cloud-sdk-java-backlog#ISSUENUMBER.
API enabling users to add custom headers from generated
*Apiclasses.This is simply alternative to what is presented in #1129
Pro: custom header api directly visible to user without directly instantiating
ApiClientinstanceCon: Its only the header that is customizable. Any addition customization (eg: query params) -> addition of new api
Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated