Conversation
Collaborator
Author
|
updating the decorator behavior would be tedious, and not as convenient as i wanted it to be, ie it would need the partial decorator: which is a one liner but still uses fancy stuff on the other hand the current approach is more lines but more simple: more stuff to keep track of but also so much easier to implement and the decorator still works for one level scope :) |
recursix
approved these changes
Dec 3, 2024
Collaborator
recursix
left a comment
There was a problem hiding this comment.
Very simple.
Does the main_tracker cost report sub_tracker + other_usager or it just report Other_usage i.e. everything tracked under sub_tracker is not seen by the main tracker?
Collaborator
Author
|
main_tracker trasks everything inside its scope following this test AgentLab/tests/llm/test_tracking.py Line 78 in c457295 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.