Fix flaky http-reverse-proxy test by using OS-assigned ports#7200
Merged
gonzaloriestra merged 1 commit intomainfrom Apr 7, 2026
Merged
Fix flaky http-reverse-proxy test by using OS-assigned ports#7200gonzaloriestra merged 1 commit intomainfrom
gonzaloriestra merged 1 commit intomainfrom
Conversation
Replace getAvailableTCPPort() with port 0 in listen() calls to eliminate the TOCTOU race condition where a port returned by getAvailableTCPPort() could be claimed by another process before the server binds to it. When listen() fails silently (unhandled error), the promise never resolves and the test hangs until the 5000ms timeout fires. Also simplifies the test fixtures by merging the ports and servers fixtures into a single setup fixture, since ports are now derived from the actual server addresses.
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
ryancbahan
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
There's a flaky test:
Example: https://github.com/Shopify/cli/actions/runs/24026356767/job/70065586128
WHAT is this pull request doing?
Replace
getAvailableTCPPort()with port 0 inlisten()calls to eliminate the TOCTOU race condition where a port could be claimed by another process before the server binds to it.When
listen()fails silently (unhandled error), the promise never resolves and the test hangs until the 5000ms timeout fires.Also simplifies the test fixtures by merging the ports and servers fixtures into a single setup fixture, since ports are now derived from the actual server addresses.
How to test your changes?
CI
Measuring impact
How do we know this change was effective? Please choose one:
Checklist