Skip to content

Increase timeout for app scaffold E2E test#7214

Merged
gonzaloriestra merged 1 commit intomainfrom
fix-e2e-timeout
Apr 7, 2026
Merged

Increase timeout for app scaffold E2E test#7214
gonzaloriestra merged 1 commit intomainfrom
fix-e2e-timeout

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

@gonzaloriestra gonzaloriestra commented Apr 7, 2026

WHY are these changes introduced?

E2E tests are failing: https://github.com/Shopify/cli/actions/runs/24074489062/job/70219371094?pr=7212

  1) tests/app-scaffold.spec.ts:9:3 › App scaffold › init creates a react-router app and builds ────

    Test timeout of 180000ms exceeded.

    attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results/app-scaffold-App-scaffold--4f777-react-router-app-and-builds/trace.zip
    Usage:

        npx playwright show-trace test-results/app-scaffold-App-scaffold--4f777-react-router-app-and-builds/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

The test was failing at exactly 3 minutes (the Playwright timeout), with the create-app init step still running (npm install for the react-router template). The key mismatch was:

  • Playwright test timeout: 3 minutes (in playwright.config.ts)
  • Fixture operation timeouts: 5 minutes each for init() and build()
  • Actual time needed: init alone took 3+ minutes due to npm install for react-router

WHAT is this pull request doing?

The fix gives this specific test 5 minutes, which aligns with the individual operation timeouts already set in the fixture. The other tests (extension-only init, toml validation, dev server, etc.) all completed in under 30 seconds, so the default 3-minute global timeout is fine for them.

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing, so I've added a changelog entry with pnpm changeset add

@gonzaloriestra gonzaloriestra marked this pull request as ready for review April 7, 2026 10:29
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner April 7, 2026 10:29
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit 897b69f Apr 7, 2026
25 checks passed
@gonzaloriestra gonzaloriestra deleted the fix-e2e-timeout branch April 7, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants