Increase timeout for app scaffold E2E test#7214
Merged
gonzaloriestra merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
isaacroldan
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
E2E tests are failing: https://github.com/Shopify/cli/actions/runs/24074489062/job/70219371094?pr=7212
The test was failing at exactly 3 minutes (the Playwright timeout), with the create-app init step still running (npm install for the react-router template). The key mismatch was:
WHAT is this pull request doing?
The fix gives this specific test 5 minutes, which aligns with the individual operation timeouts already set in the fixture. The other tests (extension-only init, toml validation, dev server, etc.) all completed in under 30 seconds, so the default 3-minute global timeout is fine for them.
How to test your changes?
CI
Checklist
pnpm changeset add