Skip to content

Enable E2E tests locally #7215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaloriestra merged 2 commits into from
Apr 7, 2026
Merged

Enable E2E tests locally #7215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89fc3e6
Install required tools on dev up
gonzaloriestra Apr 7, 2026
ed6a090
Allow specifying a custom package manager via env var
gonzaloriestra Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@ up:
# Always fetch these on dev up
met?: pnpm graphql-codegen:get-graphql-schemas
meet: 'true'
- custom:
name: 'Install Playwright Chromium'
met?: cd packages/e2e && npx playwright install chromium
meet: 'true'
- custom:
name: 'Rebuild node-pty'
met?: pnpm rebuild node-pty
meet: 'true'

env:
SHOPIFY_CLI_ENV: development
Expand Down
3 changes: 2 additions & 1 deletion packages/e2e/setup/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ export const appScaffoldFixture = authFixture.extend<{appScaffold: AppScaffold}>
async init(opts: AppInitOptions) {
const name = opts.name ?? 'e2e-test-app'
const template = opts.template ?? 'reactRouter'
const packageManager = opts.packageManager ?? 'npm'
const packageManager =
opts.packageManager ?? (process.env.E2E_PACKAGE_MANAGER as AppInitOptions['packageManager']) ?? 'npm'

const args = [
'--name',
Expand Down
1 change: 0 additions & 1 deletion packages/e2e/tests/app-deploy.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ test.describe('App deploy', () => {
// Step 1: Create an extension-only app (no scopes needed for deploy)
const initResult = await appScaffold.init({
template: 'none',
packageManager: 'npm',
})
expect(initResult.exitCode).toBe(0)

Expand Down
1 change: 0 additions & 1 deletion packages/e2e/tests/app-dev-server.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ test.describe('App dev server', () => {
// Step 1: Create an extension-only app (no scopes needed)
const initResult = await appScaffold.init({
template: 'none',
packageManager: 'npm',
})
expect(initResult.exitCode).toBe(0)

Expand Down
3 changes: 0 additions & 3 deletions packages/e2e/tests/app-scaffold.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ test.describe('App scaffold', () => {
const initResult = await appScaffold.init({
template: 'reactRouter',
flavor: 'javascript',
packageManager: 'npm',
})
expect(initResult.exitCode).toBe(0)
// Ink writes to stderr
Expand All @@ -38,7 +37,6 @@ test.describe('App scaffold', () => {
const initResult = await appScaffold.init({
name: 'e2e-ext-only',
template: 'none',
packageManager: 'npm',
})
expect(initResult.exitCode).toBe(0)
expect(fs.existsSync(appScaffold.appDir)).toBe(true)
Expand All @@ -54,7 +52,6 @@ test.describe('App scaffold', () => {
await appScaffold.init({
template: 'reactRouter',
flavor: 'javascript',
packageManager: 'npm',
})

const extensionConfigs = [
Expand Down
Loading