Skip to content

Bug: Closed caption keyvalues may not parse correctly in certain edge cases and spew garbage #1261

@pivotman319-owo

Description

@pivotman319-owo

Describe the bug

Not exclusive to Strata engine branch. See ValveSoftware/Source-1-Games#6770

chaos_2024-11-28_20-10-21

raw failing closecaption kv in subtitles_english.dat, as of latest P2CE staging build:
glados.testchambermisc23 as-is in subtitles_english.dat

same failing closecaption kv in raw datafile (subtitles_english.txt):

        "glados.testchambermisc23"    "<clr:163,193,173><B>GLaDOS:<B> You know how I'm going to live forever, but you're going to be dead in sixty years? Well, I've been working on a belated birthday present for you. Well, more of a belated birthday medical procedure. Well, <I>technically,<I> it's a medical experiment. What's important is, it's a present!"

To Reproduce

  1. closecaption 1; cc_subtitles 1 in console
  2. map sp_a2_laser_relays
  3. solve the test chamber; alternatively, cc_emit glados.testchambermisc23 in console

Issue Map

Not Applicable

Expected Behavior

The CC kv value should be parsed and displayed correctly

Operating System

Windows 11 24H2 Dev Channel - 10.0.26100.2415 (ge_release_svc_betaflt_im.241116-1208) amd64fre

Metadata

Metadata

Assignees

No one assigned

    Labels

    Priority 3: MediumSomething that should be attempted/looked at for the next release, and done if possible.Size 3: MediumSomething that will take a couple days to a week to do.Type: BugThis is a problem with something that should be working one way, but isn't.What: AudioIssues relating to the sound systemWhat: EngineEngine related issues

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions