UX: Show login button when guests are not allowed#2321
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughReplaced the "reload" button with a "login" router-link in the RoomsView guest-not-allowed footer, updated related Cypress tests to remove reload-button assertions/use Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2321 +/- ##
=============================================
- Coverage 96.70% 96.69% -0.01%
Complexity 1911 1911
=============================================
Files 445 445
Lines 12892 12892
Branches 2077 2077
=============================================
- Hits 12467 12466 -1
- Misses 425 426 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PILOS
|
||||||||||||||||||||||||||||
| Project |
PILOS
|
| Branch Review |
ux-show-login-button-when-guest-not-allowed
|
| Run status |
|
| Run duration | 07m 34s |
| Commit |
|
| Committer | Samuel Weirich |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
607
|
| View all changes introduced in this branch ↗︎ | |
samuelwei
force-pushed
the
develop
branch
2 times, most recently
from
88ee280 to
bc9287a
Compare
samuelwei
force-pushed
the
ux-show-login-button-when-guest-not-allowed
branch
from
d11e112 to
3943925
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@resources/js/views/RoomsView.vue`:
- Around line 53-54: The login CTA currently uses $route.fullPath (in
RoomsView.vue router-link) which preserves the personalized token; change the
redirect query to point to the canonical room route without the token by passing
a named route + id param (e.g. set query: { redirect: { name: 'room', params: {
id: $route.params.id } } } or equivalent using the app's canonical room route
name) so the post-login redirect goes to the canonical room page and does not
include the token.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 58e63a11-d3e3-4b8d-9715-508a31b2a1bb
📒 Files selected for processing (5)
CHANGELOG.mdresources/js/views/RoomsView.vuetests/Frontend/e2e/RoomsViewFilesFileActions.cy.jstests/Frontend/e2e/RoomsViewGeneral.cy.jstests/Frontend/e2e/RoomsViewMeetings.cy.js
💤 Files with no reviewable changes (1)
- tests/Frontend/e2e/RoomsViewFilesFileActions.cy.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Checklist
Changes
Other information
Before
After
Summary by CodeRabbit