refactor: replace timing hacks with structured signals#600
Merged
Conversation
- Remove redundant configureWelcomeWindow() polling (windowDidBecomeKey handles it) - Replace Phase 2 query delays with Task(priority: .background) - Replace 16ms tab-switch sleep with Task.yield() - Replace connection form window polling with NSWindow.didBecomeKeyNotification - Replace 300ms notification delay with pending URL pattern - Replace WindowOpener 5s polling with continuation-based readiness signal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces 6 timing hacks (polling loops, arbitrary delays) with proper structured alternatives:
configureWelcomeWindow()windowDidBecomeKeyalready handles stylingTask.sleepbefore row count/enum fetchTask(priority: .background)— proper deprioritizationTask.sleepfor onChange settleTask.yield()— yields without fixed durationNSApp.windowsNSWindow.didBecomeKeyNotificationobserverasyncAfterbefore notificationsetUp()consumes stored URLopenWindow != nilCheckedContinuationwith 5s timeout viaTaskGroupTest plan