Added Implementation of BST#4
Merged
r0hit-gupta merged 3 commits intoTheAlgorithms:masterfrom Aug 7, 2017
Merged
Conversation
Member
Author
|
Implementation of BST |
r0hit-gupta
requested changes
Aug 5, 2017
Member
r0hit-gupta
left a comment
r0hit-gupta
left a comment
There was a problem hiding this comment.
This PR looks really good to me. But here is something I would like to you to consider:
-
Please provide a meaningful name to the file.
bst.jsis not a good choice in my opinion. -
Add a proper response when searched element is not found in the tree.
added 2 commits
August 5, 2017 23:42
Member
Author
|
Thanks for suggestion
|
r0hit-gupta
approved these changes
Aug 5, 2017
Member
Author
|
Should I add anything more to the Binary Search Tree Implementation |
Member
|
No. This is good. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.