feat: add testcase of polynom_for_points#11811
Merged
cclauss merged 3 commits intoTheAlgorithms:masterfrom Oct 7, 2024
Merged
Conversation
algorithms-keeper
bot
added
enhancement
cclauss
reviewed
Oct 6, 2024
Comment on lines
+30
to
+32
| >>> print(points_to_polynomial([[1, 1], [1, 2], [1, 3]])) | ||
| x=1 | ||
| >>> print(points_to_polynomial([[1, 1], [2, 2], [2, 2]])) |
Member
There was a problem hiding this comment.
Please try removing the print()...
Suggested change
| >>> print(points_to_polynomial([[1, 1], [1, 2], [1, 3]])) | |
| x=1 | |
| >>> print(points_to_polynomial([[1, 1], [2, 2], [2, 2]])) | |
| >>> points_to_polynomial([[1, 1], [1, 2], [1, 3]]) | |
| x=1 | |
| >>> points_to_polynomial([[1, 1], [2, 2], [2, 2]]) |
Contributor
Author
There was a problem hiding this comment.
Please try removing the
print()...
@cclauss now check I removed the print statement but I did't see any major change in output
Member
There was a problem hiding this comment.
That sounds right because calling print() is not usually needed in doctests. Can you please remove print() from all tests in this file then I think we can land this.
Contributor
Author
There was a problem hiding this comment.
hi @cclauss check I removed the print from remaining place of polynom_for_points test cases
algorithms-keeper
bot
removed
the
awaiting reviews
fortarch
pushed a commit
to fortarch/algorithms-python
that referenced
this pull request
Oct 7, 2024
* feat: add testcase of polynom_for_points * fix: remove the print from the testcase of points_to_polynomial * fix: remove print statement from old test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist: