Update contribution guidelines, add note for windows users #12352

[edlerd]

Describe your change:

• Documentation change

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Done

• Updated contributing guidelines with a hint for Windows users to execute the pre commit hooks.

Fixes #12352

[edlerd]

The failing ruff test seems unrelated.

I tried removing the noqa: ... comment as ruff suggests, but then pre commit step of CI fails.

[cclauss]

Windows users should use py

Or in a venv, everyone should use python

[edlerd]

Yes, but we cannot make such assumptions for pre commit hooks, they rely on the python3 command.

[cclauss]

#12371

[cclauss]

Ruff was fixed in #12370 if you rebase.

• [pre-commit.ci] pre-commit autoupdate #12370

Which pre-commit hook fails on Windows?

[edlerd]

Ruff was fixed in #12370 if you rebase.

thx, will rebase this tomorrow morning.

Which pre-commit hook fails on Windows?

I came here because of this issue: #12352 It details on what exactly the problem is and is pointing to the solution I added to the docs with this change.

[edlerd]

Closing this, because #12371 fixes it in a better way.