EmpyPopTracker fix - items would not show green when obtained#1838
Merged
z16 merged 1 commit intoWindower:devfrom Mar 2, 2020
xurion:dev
Merged
EmpyPopTracker fix - items would not show green when obtained#1838z16 merged 1 commit intoWindower:devfrom xurion:dev
z16 merged 1 commit intoWindower:devfrom
xurion:dev
Conversation
Fixed issue where items would not show green. Updated addon description.
z16
added a commit
that referenced
this pull request
Nov 4, 2024
EmpyPopTracker fix - items would not show green when obtained
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a derp from me where the loop over the bags used ipairs and therefore did not iterate over any bags (they're referenced by name and not index). I guess I just checked KIs were turning green and not regular items 🤷♂
Also had to put a check in for the data type of the bag being a table because
get_items()returns things like gil and max storage counts (line 72).Updated addon description to cover non-Abyssea NMs.
xurion/ffxi-empy-pop-tracker#5