Merged
Conversation
Updating local repository
I have restructured parts of Salvage2 so that it uses the new Texts for boxes, and it now works again.
Change textbox method to use Texts, and made other structure adjustments.
Updating local repository
This reverts commit 4554c09.
z16
requested changes
Apr 10, 2020
Member
z16
left a comment
z16
left a comment
There was a problem hiding this comment.
Hope you appreciate my constructive and detailed code review!
Contributor
Author
|
@z16 , your feedback is always welcome. Especially when I haven't touched the addons in nearly 2 years. I removed settings.xml from my source and pushed that. I've made the tabs change, but I won't push that one until after my next Salvage run to make sure I didn't screw up a simple find/replace. |
z16
approved these changes
Apr 10, 2020
Parenthesis and tabs
Contributor
Author
|
Committed the last of the changes. I included the THTracker parenthesis and tabs as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Salvage2 finally. I used TH Tracker as a baseline since it works. Salvage2 now uses Texts instead of the previous method. for the textboxes, and the settings are structured different. Not sure if it made a difference, but I also adjusted the chat message checks to the format I saw being used. Overall code cleanup as well with the implementation of Texts.
I've done the same thing with DynamisHelper, but it requires a little more testing to ensure it is fully functional again.