[thtracker] Update to use packets#2052
Merged
z16 merged 1 commit intoWindower:devfrom Jul 13, 2021
KenshiDRK:thtracker
Merged
Conversation
Update th tracker to use packets instead of text
z16
approved these changes
Jul 13, 2021
| settings = config.load(defaults) | ||
|
|
||
| th = texts.new('No current mob', settings) | ||
| th = texts.new('${th_string}', settings) |
Member
There was a problem hiding this comment.
If a text box contains no actual variable splicing (as in, the entire text box is just one variable), it performs better to not use variables and just update the entire text with th:text(new_text). Not a real issue, just mentioning it for future development.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update th tracker to use packets instead of text.