Merged
Conversation
z16
pushed a commit
that referenced
this pull request
Nov 4, 2024
eager-load resources for actions.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
resourceslib lazy-loads resources using a metatable to avoid extra RAM overhead where it loads resources it doesn't need.The
actionslib bypasses its metatables (line 203 with the rawgets) to avoid the performance hit they cause.While both design decisions make sense in isolation, unfortunately this means you must index the resources you're going to parse actions out of once or it'll throw obscure rawget errors.
I fixed this in both gearswap and libs/actions.lua