Conversation
z16
added a commit
that referenced
this pull request
Nov 4, 2024
make it possible to access text settings again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pointwatch is basically a text box that updates, so I wanted to expose as much functionality as possible. As such, it just directly exposes approved methods of the texts library and was pirating/serializing the metadata in its own settings. Changes you made almost a decade ago broke this, probably not knowingly but to prevent people from doing this because they would run into problems if someone changed the internal workings of the library.
However, wrapping every method of the texts library is almost as much work as just writing your own library that uses the underlying
windower.functions. Given how stable the texts library is, could we just expose a.settings()method at this point (or the old_settingsproperty)?