Conversation
Consistent changes to Itemizer: - added auto-stacking of the destination bag when moving partial stacks of stackable items, along with a setting for the functionality, and a manual argument to invoke it. - changed the previous fix to the recognition of high quality item names (ending in `+1`, `+2`, etc) to include any other non-digit character (i.e `#`) - changed help text to reflect the new functionality (and fixed capitalization) - changed all instances of `windower.add_to_chat()` to use `log()` instead, since it's using the `luau` library anyway - changed version-recognizing logic so that it recognizes changes in major and minor versions automatically without the need for hardcoded values - bumped version number I am, tentatively, not using the packets library for the stacking functionality, since it adds a good bit of overhead and there can be situations where the addon might be spamming stacking commands, especially when the //put commands are invoked via scripts - as it's common. On the other hand, the addon is already using item resources which is a lot of overhead on its own, so I am not sure if it would be better to use the packets lib as well at that point. I'm open to suggestions.
Removed a require that I had forgot to remove after testing.
Fixed a copypaste error and a tidied up a variable name.
Adjusted version check so that it only fires when the user is logged in all the way and thus the chatlog is available to print the notice.
Fixed commas and string formatting.
lili-ffxi
added a commit
that referenced
this pull request
Sep 8, 2023
`log()` can translate booleans directly into strings whereas `string.format()` doesn't.
z16
pushed a commit
that referenced
this pull request
Nov 4, 2024
* Added functionality to Itemizer Significant changes to Itemizer: - added auto-stacking of the destination bag when moving partial stacks of stackable items, along with a setting for the functionality, and a manual argument to invoke it. - changed the previous fix to the recognition of high quality item names (ending in `+1`, `+2`, etc) to include any other non-digit character (i.e `#`) - changed help text to reflect the new functionality (and fixed capitalization) - changed all instances of `windower.add_to_chat()` to use `log()` instead, since it's using the `luau` library anyway - changed version-recognizing logic so that it recognizes changes in major and minor versions automatically without the need for hardcoded values - Adjusted version check so that it only fires when the user is logged in all the way and thus the chatlog is available to print the notice. - bumped version number I am, tentatively, not using the packets library for the stacking functionality, since it adds a good bit of overhead and there can be situations where the addon might be spamming stacking commands, especially when the //put commands are invoked via scripts - as it's common. On the other hand, the addon is already using item resources which is a lot of overhead on its own, so I am not sure if it would be better to use the packets lib as well at that point. I'm open to suggestions.
z16
pushed a commit
that referenced
this pull request
Nov 4, 2024
`log()` can translate booleans directly into strings whereas `string.format()` doesn't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistent changes to Itemizer:
+1,+2, etc) to include any other non-digit character (i.e#)windower.add_to_chat()to uselog()instead, since it's using theluaulibrary anywayI am, tentatively, not using the packets library for the stacking functionality, since it adds a good bit of overhead and there can be situations where the addon might be spamming stacking commands, especially when the //put commands are invoked via scripts - as it's common. On the other hand, the addon is already using item resources which is a lot of overhead on its own, so I am not sure if it would be better to use the packets lib as well at that point. I'm open to suggestions.