Skip to content

[EquipViewer] Add draggable option for UI elements#2529

Open
aragan wants to merge 1 commit intoWindower:devfrom
aragan:patch-8
Open

[EquipViewer] Add draggable option for UI elements#2529
aragan wants to merge 1 commit intoWindower:devfrom
aragan:patch-8

Conversation

@aragan
Copy link
Copy Markdown
Contributor

@aragan aragan commented Mar 28, 2026

Add draggable option for UI elements

Add draggable option for UI elements
@RubenatorX RubenatorX changed the title Add draggable option for UI elements [EquipViewer] Add draggable option for UI elements Mar 28, 2026
@RubenatorX
Copy link
Copy Markdown
Collaborator

It's helpful if you talk to an addon Author before submitting a PR, but I'll let you know what I was planning and what I need changed in order to accept it.
Also, in the future please always include the name of the addon/thing you're changing in square braces at the start of your PR (in this case) [EquipViewer] (I have edited the title as such).

  1. You wrote an entire function, position_all_ui_elements, that is basically a non-destructive duplication of setup_ui. Instead, should add an optional flag to setup_ui to make it nondestructive, and call it with the flag.
  2. I won't accept draggable as being a save-able setting. it should be a temporary addon state, toggleable with a command move instead (instead of drag/draggable), and only save the config after it is toggled off. Also should not have an off/on command option. Relevant instructions and feedback should be conveyed to the user when this is toggled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants