cloudfoundry#1237 bleeding edge jorbaum by jorbaum · Pull Request #2 · ZPascal/cf-java-client

jorbaum · 2026-02-26T16:15:11Z

Please merge with rebase

Commit messages say it all.

ZPascal

We should discuss the strategy for shipping the changes (breaking vs. non-breaking).

...c/main/java/org/cloudfoundry/reactor/tokenprovider/_ClientCredentialsGrantTokenProvider.java

...t-reactor/src/main/java/org/cloudfoundry/reactor/tokenprovider/AbstractUaaTokenProvider.java

...y-operations/src/main/java/org/cloudfoundry/operations/applications/DefaultApplications.java

...erations/src/test/java/org/cloudfoundry/operations/applications/DefaultApplicationsTest.java

...y-operations/src/main/java/org/cloudfoundry/operations/applications/DefaultApplications.java

cloudfoundry-client/src/main/java/org/cloudfoundry/doppler/DopplerClient.java

jorbaum · 2026-03-20T15:55:51Z

Added new commits that should address requested changes in cloudfoundry#1237 .

Here are follow up links that show when /read endpoint of log cache has been added:

Use LogCacheClient.read() for recent logs (the default), fall back to Doppler streaming when recent is explicitly false. Remove logCacheLogs() integration test — it was a temporary reference for the direct LogCache API, now redundant since logs() exercises the same path. Remove logsRecent() and its helpers likewise.

LogCache has been available since cf-deployment v3.0.0 (July 2018). Lower the version gate from PCF_4_v2 to PCF_2_3 and update the javadoc to reflect that the test now exercises the LogCache-backed path.

logs(ApplicationLogsRequest) now uses Log Cache internally, so Operations API users do not need to migrate.

Kehrlann

Looks good, minor comments; the important bit is keeping @Deprecated but deprecated

Kehrlann · 2026-03-23T13:41:43Z

...dfoundry-operations/src/main/java/org/cloudfoundry/operations/applications/Applications.java

-     * List the applications logs.
-     * Only works with {@code Loggregator < 107.0}, shipped in {@code CFD < 24.3}
-     * and {@code TAS < 4.0}.
+     * List the applications logs. Uses Log Cache under the hood.


Please add a caveat that only "recent logs" use logcache, while streaming logs use Doppler and only work with Loggregator < 107.0 / CFC < 24.3

AFAIU the "only work with Loggregator < 107.0 / CFC < 24.3" part is not accurate for streaming logs.

Loggregator v107.0.0 only removed the RecentLogsHandler from Traffic Controller - not Doppler or the streaming endpoints. The Doppler instance group is still present in the cf-deployment manifest at both v24.3.0 and the latest v55.0.0.

My suggestion would be to add a note clarifying that only recent logs use LogCache, while streaming logs still use Doppler (which remains available on current CF deployments just not in the new Shared Nothing Architecture).

ah, awesome! thanks for the clarification 🙏

Kehrlann · 2026-03-23T13:46:27Z

...dfoundry-operations/src/main/java/org/cloudfoundry/operations/applications/Applications.java

-     * @param request the application logs request
-     * @return the applications logs
-     */
-    Flux<Log> logsRecent(ReadRequest request);


Keep the method and mark it @Deprecated, we'll remove it in 6.0

This removes the method from our branch, not from the main branch. Are you sure this is what you mean? It is kind of weird to introduce a new method and mark it as @deprecated ?

My bad, got confused with both PRs. Let's not introduce this.

Kehrlann · 2026-03-23T13:50:51Z

...y-operations/src/main/java/org/cloudfoundry/operations/applications/DefaultApplications.java

-                                                ApplicationLogType.from(
-                                                        logMessage.getMessageType().name()))
-                                        .build());
+        if (Optional.ofNullable(request.getRecent()).orElse(true)) {


Consider something more straightforward

Suggested change

if (Optional.ofNullable(request.getRecent()).orElse(true)) {

if ((request.getRecent() != null || request.getRecent() == true)) {

jorbaum

Sorry for the confusion.

I did not expect you, @Kehrlann reviewing this here :P . This is the bleeding edge branch where @ZPascal and I discuss some changes before we deem it ready for review :) .

Still, I definitely value and welcome your feedback! Thanks!

jorbaum · 2026-03-23T16:59:44Z

...dfoundry-operations/src/main/java/org/cloudfoundry/operations/applications/Applications.java

-     * @param request the application logs request
-     * @return the applications logs
-     */
-    Flux<Log> logsRecent(ReadRequest request);


This removes the method from our branch, not from the main branch. Are you sure this is what you mean? It is kind of weird to introduce a new method and mark it as @deprecated ?

jorbaum · 2026-03-23T17:10:03Z

...dfoundry-operations/src/main/java/org/cloudfoundry/operations/applications/Applications.java

-     * List the applications logs.
-     * Only works with {@code Loggregator < 107.0}, shipped in {@code CFD < 24.3}
-     * and {@code TAS < 4.0}.
+     * List the applications logs. Uses Log Cache under the hood.


AFAIU the "only work with Loggregator < 107.0 / CFC < 24.3" part is not accurate for streaming logs.

Loggregator v107.0.0 only removed the RecentLogsHandler from Traffic Controller - not Doppler or the streaming endpoints. The Doppler instance group is still present in the cf-deployment manifest at both v24.3.0 and the latest v55.0.0.

My suggestion would be to add a note clarifying that only recent logs use LogCache, while streaming logs still use Doppler (which remains available on current CF deployments just not in the new Shared Nothing Architecture).

jorbaum force-pushed the issue-1181-joris branch from f40fbee to da3e2c9 Compare February 26, 2026 16:18

ZPascal force-pushed the issue-1181-new branch from 210376c to b39e647 Compare February 26, 2026 16:20

jorbaum force-pushed the issue-1181-joris branch from da3e2c9 to b0f6345 Compare February 27, 2026 07:01

ZPascal requested changes Feb 27, 2026

View reviewed changes

ZPascal reviewed Feb 27, 2026

View reviewed changes

cloudfoundry-client/src/main/java/org/cloudfoundry/doppler/DopplerClient.java Outdated Show resolved Hide resolved

jorbaum force-pushed the issue-1181-joris branch 5 times, most recently from 19f2787 to a3d858e Compare February 27, 2026 07:27

jorbaum changed the base branch from issue-1181-new to issue-1181 February 27, 2026 07:29

jorbaum force-pushed the issue-1181-joris branch 6 times, most recently from 3f23bef to ad6bacf Compare March 5, 2026 11:16

jorbaum force-pushed the issue-1181-joris branch from ad6bacf to b7800f7 Compare March 20, 2026 15:53

jorbaum changed the title ~~Fix some issues that I found~~ cloudfoundry#1237 bleeding edge jorbaum Mar 20, 2026

jorbaum added 3 commits March 23, 2026 10:49

Update logs() integration test javadoc and version gate

4e05f86

LogCache has been available since cf-deployment v3.0.0 (July 2018). Lower the version gate from PCF_4_v2 to PCF_2_3 and update the javadoc to reflect that the test now exercises the LogCache-backed path.

Add Operations API note to README deprecation section

dd0ffb0

logs(ApplicationLogsRequest) now uses Log Cache internally, so Operations API users do not need to migrate.

jorbaum force-pushed the issue-1181-joris branch from b7800f7 to dd0ffb0 Compare March 23, 2026 09:51

Kehrlann reviewed Mar 23, 2026

View reviewed changes

jorbaum commented Mar 23, 2026

View reviewed changes

	if (Optional.ofNullable(request.getRecent()).orElse(true)) {
	if ((request.getRecent() != null \|\| request.getRecent() == true)) {

Conversation

jorbaum commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZPascal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jorbaum commented Mar 20, 2026

Uh oh!

Kehrlann left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jorbaum left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jorbaum commented Feb 26, 2026 •

edited

Loading