Increase ClientOptions mutability safety by cloning objects#827
Merged
qsdigor merged 15 commits intointegration/version-2from Aug 1, 2022
Merged
Conversation
…y with config files
Fix TokenDetails equals() method by checking instance before casting
Fix ClientOptions copy method
…lity-safety-by-cloning-objects # Conflicts: # core/src/main/java/io/ably/lib/util/ObjectCopyUtil.java
KacperKluka
suggested changes
Jul 21, 2022
Contributor
KacperKluka
left a comment
KacperKluka
left a comment
There was a problem hiding this comment.
A few questions and suggestions 😉
core/src/test/java/io/ably/lib/test/realtime/RealtimeAuthTest.java
Outdated
Show resolved
Hide resolved
added 2 commits
July 22, 2022 09:22
Remove comment about deep copy as we do not need it
ikbalkaya
suggested changes
Jul 25, 2022
Contributor
ikbalkaya
left a comment
ikbalkaya
left a comment
There was a problem hiding this comment.
I have made some suggestions
core/src/test/java/io/ably/lib/test/realtime/RealtimeAuthTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/io/ably/lib/test/realtime/RealtimeAuthTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/io/ably/lib/test/realtime/RealtimeAuthTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ikbal Kaya <ceikbal@gmail.com>
ikbalkaya
reviewed
Jul 26, 2022
Co-authored-by: Ikbal Kaya <ceikbal@gmail.com>
ikbalkaya
approved these changes
Jul 27, 2022
qsdigor
changed the title
qsdigor
deleted the
feature/771-increase-mutability-safety-by-cloning-objects
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ObjectCopyUtil with copy method for ClientOptions. Changing fields in options after it is passed to AblyRealtime will no longer change options in the AblyRealtime instance.